fix(DatePicker2): support defaultValue for quarter, close #3006 #4985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mwb-27
force-pushed
the
fix-issue-3006
branch
4 times, most recently
from
71a3e4b to
ef1f4a0
Compare
zyliang96
approved these changes
Dec 5, 2024
components/util/func.ts
Outdated
| @@ -1,6 +1,7 @@ | |||
| import type { ConfigType, OptionType, Dayjs } from 'dayjs'; | |||
| import { isPromise } from './object'; | |||
| import datejs from './date'; | |||
| import { isArray } from 'lodash'; | |||
There was a problem hiding this comment.
是不是直接用Array.isArray 就可以处理了，不用引入lodash
components/util/func.ts
Outdated
| /** | ||
| * 字符型日期转为dayjs类型 | ||
| */ | ||
| export function getValueWithDayjs(val: ConfigType | ConfigType[], format: OptionType) { |
components/util/func.ts
Outdated
| let date = val; | ||
|
|
||
| if (isArray(val)) { | ||
| date = [0, 1].map(index => { |
There was a problem hiding this comment.
这个地方直接对date做处理就好了，取[0,1]就限制了长度，工具方法不通用
mwb-27
force-pushed
the
fix-issue-3006
branch
from
ef1f4a0 to
44f082c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.