Skip to content

Commit

Permalink
Fix Dubbo SPI path in Dubbo 3 adapter and improve test cases (#2822)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlbumenJ authored Aug 17, 2022
1 parent 24ac1be commit bef6574
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 3 deletions.
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sentinel.dubbo.provider.filter=com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboProviderFilter
sentinel.dubbo.provider.filter=com.alibaba.csp.sentinel.adapter.dubbo3.SentinelDubboProviderFilter
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
dubbo.application.context.name.filter=com.alibaba.csp.sentinel.adapter.dubbo.DubboAppContextFilter
sentinel.dubbo.consumer.filter=com.alibaba.csp.sentinel.adapter.dubbo.SentinelDubboConsumerFilter
dubbo.application.context.name.filter=com.alibaba.csp.sentinel.adapter.dubbo3.DubboAppContextFilter
sentinel.dubbo.consumer.filter=com.alibaba.csp.sentinel.adapter.dubbo3.SentinelDubboConsumerFilter
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
/*
* Copyright 1999-2018 Alibaba Group Holding Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.alibaba.csp.sentinel.adapter.dubbo3;

import org.apache.dubbo.rpc.Filter;
import org.apache.dubbo.rpc.cluster.filter.ClusterFilter;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;

import org.junit.Assert;
import org.junit.Test;

import java.util.Set;

public class SentinelFilterTest {
@Test
public void test() {
ApplicationModel applicationModel = FrameworkModel.defaultModel().newApplication();
ModuleModel moduleModel = applicationModel.newModule();
Set<Filter> filters = moduleModel.getExtensionLoader(Filter.class).getSupportedExtensionInstances();
Assert.assertTrue(filters.stream().anyMatch(f -> f instanceof SentinelDubboProviderFilter));

Set<ClusterFilter> clusterFilters = moduleModel.getExtensionLoader(ClusterFilter.class).getSupportedExtensionInstances();
Assert.assertTrue(clusterFilters.stream().anyMatch(f -> f instanceof DubboAppContextFilter));
Assert.assertTrue(clusterFilters.stream().anyMatch(f -> f instanceof SentinelDubboConsumerFilter));

applicationModel.destroy();
}
}

0 comments on commit bef6574

Please sign in to comment.