[ui] Add and improve multiple UI tools for Photometric stereo #2444
+2,295
−1,689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregoire-dl
added
feature
3 tasks
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
df3239d
to
8f8d8aa
Compare
cbentejac
force-pushed
the
dev/qt6.6
branch
3 times, most recently
from
fa58a2e
to
9865cb8
Compare
This fixes all the "Injection of parameters into signal handlers is deprecated. Use JavaScript functions with formal parameters instead." warnings.
Qt3D.Extras cannot be updated to 2.6 yet, otherwise there are errors.
With Qt6, OpenGL is not used directly anymore, and we thus must use the RHI backend, set to version 1.0. The SphericalHarmonics shaders, which were previously written in OpenGL, need to be updated accordingly.
Call the `QGeometry` objects from the correct module, and initialize correctly the Camera object upon the construction of the TrackballController object.
Additionally harmonize comments and explicitly declare parameters for slots that need them.
`QtQuick.Window` does not exist anymore with Qt6. QQuickWindow is now directly part of the QtQuick module.
When the SequencePlayer isn't available (when QtAliceVision has not been loaded), the `viewer` element is null. All accesses to properties of this object should thus be prevented.
This prevents crashes when the project is done loading but `Application` is not yet ready.
QMouseEvent::x() and QMouseEvent::y() have been marked as deprecated and should be replaced with QMouseEvent::position().x() and QMouseEvent::position().y().
The curve scale of the mouse area for an edge used to be defined when initializing the `EdgeMouseArea` for that edge. Setting it triggers a chain of event that allow the mouse area to be active, thus correctly detecting when it is being hovered or clicked on. With Qt6, these events unfolded before the `EdgeMouseArea` had finished initializing, which then caused it to not be active until the edge's shape was modified (and the chain of events triggered again). It is now set once the component has been created, so all the events can happen in an environment where they are taken into account.
The callbacks of `childrenRepeater` (which was used to "fill" `ListAttributes` with children) were not correctly set. Their prototypes were missing the `index` argument, meaning that instead of being provided with the child attribute that was added or deleted, they were provided with its index in the model. The added children attributes were also instatiated as empty attribute pins that were still visible, thus increasing indirectly the spacing of the initial pin.
Use a single light entity instead of one per camera. Use directional light instead of point light. Add camera relative directional light controller.
Default camera up should be accurate and consistent with camera view center. Default camera up vector is not refresh or checked when default camera view center is set.
cbentejac
force-pushed
the
dev/qt6.6_phongImageViewer
branch
from
8f8d8aa
to
68ee345
Compare
cbentejac
force-pushed
the
dev/qt6.6
branch
2 times, most recently
from
e7e2e2d
to
f818005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the new QtAliceVision 2D viewer with toolbar and a new light direction controller.
A normal map with two light directions.
Add the ability to change the camera-relative light direction in the 3D viewer
Same object with two different light directions using the new light direction controller.
Improve
SphereDetectionwidget in order to handle automatic detection of calibration spheres.Automatically detected calibration sphere shown with the green circle.
Features list
SphereDetectionwidget in order to handle automatic detection of calibration spheres.Implementation remarks
This PR is based on the Qt6 migration branch: https://github.com/alicevision/Meshroom/tree/dev/qt6.6
Linked to QtAliceVision PR: alicevision/QtAliceVision#72