-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiclass: Adjusted and pythonized plotting functions in mlperformance.py #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…honization in models.py, helper function in utilities_plot
…ision-recall, pylint, adjust optimiser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last big PR of multiclass refactor. BinaryClassification results stay the same. Notes:
cross_val_predict
if there could be multiple classifiers compared on a single figure, andpredict_proba
for per-classifier plots. However, if we want to measure model performance, not compare it to others, then it would be better to usepredict_proba
for all plots. What are your thoughts on this?random_state
fromcross_validation_mse
as then it will use the global seedrnd_all
from the database file. So, the user has control whether he wants to do all randomly (withrnd_all = None
) or with a specific seed.