Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiclass: Adjusted and pythonized plotting functions in mlperformance.py #848

Merged
merged 25 commits into from
Dec 20, 2023

Conversation

saganatt
Copy link
Contributor

This is the last big PR of multiclass refactor. BinaryClassification results stay the same. Notes:

  1. I use cross_val_predict if there could be multiple classifiers compared on a single figure, and predict_proba for per-classifier plots. However, if we want to measure model performance, not compare it to others, then it would be better to use predict_proba for all plots. What are your thoughts on this?
  2. I removed hardcoded random_state from cross_validation_mse as then it will use the global seed rnd_all from the database file. So, the user has control whether he wants to do all randomly (with rnd_all = None) or with a specific seed.

@qgp qgp merged commit b20d1ab into alisw:run3 Dec 20, 2023
5 checks passed
@saganatt saganatt deleted the multiclass-all-plots-pr branch December 20, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants