Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a user runs "/cvmfs/alice.cern.ch/bin/alienv load O2Physics" from EL9 (e.g. lxplus), alienv skips the platform check and tries to load the latest EL7 build (since
*)
simply passes the "load" command through to environment modules and "el7" is higher on the default $moduledirs list).Adding "load" to the list of arguments for the "EXPECT_PACKAGES" check does the correct checking of the module directories before it passes the load command through to
module
.I'm not sure if it is preferred to do it this way, or to otherwise add some defined behaviour for the "alienv load" command, but ideally "alienv load" by itself shouldn't be trying to load modules from the wrong arch.
See discussion in https://mattermost.web.cern.ch/alice/pl/abagkh3oypdf8komxrgfffr9qy for details