Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct platform check #1366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jezwilkinson
Copy link

Currently, if a user runs "/cvmfs/alice.cern.ch/bin/alienv load O2Physics" from EL9 (e.g. lxplus), alienv skips the platform check and tries to load the latest EL7 build (since *) simply passes the "load" command through to environment modules and "el7" is higher on the default $moduledirs list).

Adding "load" to the list of arguments for the "EXPECT_PACKAGES" check does the correct checking of the module directories before it passes the load command through to module.

I'm not sure if it is preferred to do it this way, or to otherwise add some defined behaviour for the "alienv load" command, but ideally "alienv load" by itself shouldn't be trying to load modules from the wrong arch.

See discussion in https://mattermost.web.cern.ch/alice/pl/abagkh3oypdf8komxrgfffr9qy for details

@jezwilkinson jezwilkinson requested a review from ktf as a code owner July 17, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant