Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting variables when using system packages #795

Merged
merged 6 commits into from
Oct 3, 2023
Merged

Allow setting variables when using system packages #795

merged 6 commits into from
Oct 3, 2023

Commits on Jul 11, 2023

  1. Allow setting variables when using system packages 

    This would allow us to put setup code (e.g. finding the right python
executable, etc) in one place in python.sh.
    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a61b78b View commit details
    Browse the repository at this point in the history

  2. Use a single prefer_system_check 

    ...and parse its output to find a line selecting the replacement spec to use.
    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2952ff5 View commit details
    Browse the repository at this point in the history

  3. Remove helper for choosing replacement

    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2378edc View commit details
    Browse the repository at this point in the history

  4. Allow specifying replacement recipe

    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0f49557 View commit details
    Browse the repository at this point in the history

  5. Correctly report to the user when we compile a "system" package 

    System packages can now specify replacement recipes, in which case they aren't
really "system" packages, since we still run the potentially-expensive recipe.
Report this to the user.
    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    19306ef View commit details
    Browse the repository at this point in the history

  6. Add unit tests for replacement spec handling 

    This tests the getPackageList function, since only that was changed.
    @TimoWilken
    TimoWilken committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0763e33 View commit details
    Browse the repository at this point in the history