Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sapling #804

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Add support for sapling #804

merged 1 commit into from
Nov 1, 2023

Conversation

ktf
Copy link
Member

@ktf ktf commented Oct 13, 2023

Add support for sapling

Sapling is a somewhat novel SCM from Facebook / Meta.

It is fully compatible with Git and provides a more powerful
yet userfriendly frontend, modeled after mercurial.

This adds Sapling support in alibuild, including:

  • Support for alidist sapling checkouts
  • Support for development packages which were cloned via sapling

Copy link
Contributor

@TimoWilken TimoWilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, this doesn't look like too much added complexity, as it currently stands.

See comments below. Also, the code style isn't what's recommended for Python, but I suppose it matches much of the rest of alibuild.

alibuild_helpers/build.py Outdated Show resolved Hide resolved
alibuild_helpers/build.py Outdated Show resolved Hide resolved
alibuild_helpers/build.py Outdated Show resolved Hide resolved
alibuild_helpers/build.py Outdated Show resolved Hide resolved
alibuild_helpers/build.py Outdated Show resolved Hide resolved
@TimoWilken
Copy link
Contributor

I don't know why the tests didn't run for the latest commit, but the changes look good to me.

@ktf ktf force-pushed the pr804 branch 2 times, most recently from c598bf6 to ba3a5cd Compare October 19, 2023 07:06
Sapling is a somewhat novel SCM from Facebook / Meta.

It is fully compatible with Git and provides a more powerful
yet userfriendly frontend, modeled after mercurial.

This adds Sapling support in alibuild, including:

* Support for alidist sapling checkouts
* Support for development packages which were cloned via sapling
@ktf ktf merged commit 5dc6016 into alisw:master Nov 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants