Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to building the package if prefer_system_check fails #884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

singiamtel
Copy link
Collaborator

The current behaviour is to crash the build, but we can recover
gracefully by going back to building our own version instead.

Any trigger of this warning should be considered as a bug on the recipe,
though

The current behaviour is to crash the build, but we can recover
gracefully by going back to building our own version instead.

Any trigger of this warning should be considered as a bug on the recipe,
though
@singiamtel
Copy link
Collaborator Author

@ktf what should I do with this test? Feel awkward to just delete it, but I'm not sure what to test for with the new behaviour change

    def test_missing_replacement_spec(self, mock_dieOnError):
        """Check an error is thrown when the replacement spec is not found."""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant