-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick up the provided OpenSSL #4136
base: master
Are you sure you want to change the base?
Conversation
Without this it picks up the system version on linux.
Hello @ktf , Are these errors genuine, or could this be merged? Thanks! |
I think they are actually genuine. @Barthelemy @knopers8 could you investigate a bit? It seems to me that the cmake from QC actually picks up OpenSSL from the system. This was meant to force it to pick it up from our own build, where specified, but still it does not work. I remember you had to do something weird to pick up openssl, can you remind me what that was? |
Ok, I am now forcing the OpenSSL detection also in O2. In principle the actual issue could actually be fixed at QC level by dropping the dependency on |
Hello, Are the errors still genuine? Chiara |
Yes. It looks like gRPC is built with system openssl on cc8. |
It should be fixed in the last commit. |
Hello, |
RPATH done in this way is not relocatable, which will end up not actually picking our SSL version.
Sigh, still not ok... @ktf |
Without this it picks up the system version on linux.