Don't reset CFLAGS on python recipe #5594
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktf
reviewed
Aug 28, 2024
| @@ -54,7 +54,7 @@ esac | |||
| if [[ $OPENSSL_ROOT ]]; then | |||
| export CPATH="$OPENSSL_ROOT/include:$OPENSSL_ROOT/include/openssl:$CPATH" | |||
| export CPPFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl $CPPFLAGS" | |||
| export CFLAGS="-I$OPENSSL_ROOT/include -I$OPENSSL_ROOT/include/openssl" | |||
There was a problem hiding this comment.
Maybe what we should do is really drop CFLAFS, since most likely CPPFLAGS is enough. Could you check?
There was a problem hiding this comment.
The compilation without CFLAGS ends successfully, but I get a crash on env activation with this error:
alienv enter Python/latest-ubuntu2204_x86-64-o2
Loading Python/latest-ubuntu2204_x86-64-o2
Module ERROR: /home/admin/test_openssl_py/sw/ubuntu2204_x86-64/Python/v3.9.16-local1/bin/python3: error while loading shared libraries: libcrypt.so.2: cannot open shared object file: No such file or directory
while executing
"exec $PKG_ROOT/bin/python3 -c "import certifi; print(certifi.where())""
(file "/home/admin/test_openssl_py/sw/MODULES/ubuntu2204_x86-64/Python/latest-ubuntu2204_x86-64-o2" line 26)
Please contact <root@localhost>
singiamtel
changed the title
singiamtel
changed the title
singiamtel
changed the title
singiamtel
changed the title
|
@ktf is this okay to merge? |
|
Yes. Do we have any other Python change which we can merge at the same time (so to avoid too many rebuilds?). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we currently build without -O2 when using our own OpenSSL, seems like an oversight