Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove readline installation from xjalienfs recipe #5655

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

singiamtel
Copy link
Collaborator

Since #5534 we depend on gnureadline globally anyway, no point in reinstalling it in the recipe

CC @ktf @adriansev @sawenzel

Since alisw#5534 we depend on
gnureadline globally anyway, no point in reinstalling it in the recipe
@singiamtel singiamtel requested a review from a team as a code owner October 8, 2024 20:01
@singiamtel singiamtel requested a review from costing October 8, 2024 20:01
@adriansev
Copy link
Contributor

@ktf @singiamtel if we're gonna put a xjalienfs dependency in python-modules-list we could be consistent and add the other dependencies too .. for reference, in a fresh venv on alma9 i got this:

async-stagger==0.3.1
certifi==2024.8.30
cffi==1.17.1
charset-normalizer==3.3.2
cryptography==43.0.1
idna==3.10
markdown-it-py==3.0.0
mdurl==0.1.2
pycparser==2.22
Pygments==2.18.0
pyOpenSSL==24.2.1
requests==2.32.3
rich==13.9.2
typing_extensions==4.12.2
urllib3==2.2.3
websockets==13.1

and on fedora 40 (which have python 3.12.6)

async_stagger==0.4.0.post1
certifi==2024.8.30
cffi==1.17.1
charset-normalizer==3.3.2
cryptography==43.0.1
idna==3.10
markdown-it-py==3.0.0
mdurl==0.1.2
pycparser==2.22
Pygments==2.18.0
pyOpenSSL==24.2.1
requests==2.32.3
rich==13.9.2
setuptools==75.1.0
urllib3==2.2.3
websockets==13.1
wheel==0.44.0

@singiamtel
Copy link
Collaborator Author

I was thinking about this the other day, wouldn't it be better to have them all in https://github.com/adriansev/jalien_py/blob/master/setup.py? I think it's what we run when doing pip install on this recipe anyway

Also linking to the last PR on this discussion #5182

@adriansev
Copy link
Contributor

I was thinking about this the other day, wouldn't it be better to have them all in https://github.com/adriansev/jalien_py/blob/master/setup.py? I think it's what we run when doing pip install on this recipe anyway

Also linking to the last PR on this discussion #5182

there are already there see https://github.com/adriansev/jalien_py/blob/master/setup.py#L19-L31
of course without gnureadline because from my point of view is not really required if it is a normal python (compiled with readline) ... but i could detect the darwin arch and add it as dependency and this would solve the problem...

@sawenzel sawenzel self-requested a review October 10, 2024 11:56
@adriansev
Copy link
Contributor

so, this is really weird .. the xjalienfs test fail here
and the problem is that only alidist-slc9-aarch64 have problems while all others are ok ...
this can only be investigated directly on the machine as no matter what the problem is, it needs also to be fixed and tested :)

@adriansev
Copy link
Contributor

FWIW on my Manjaro based ARM sbc (Linux n2plus 6.4.3-1-MANJARO-ARM-ODROID #1 SMP PREEMPT Wed Aug 30 20:04:07 UTC 2023 aarch64 GNU/Linux) the tests worked without problems, so at least we know that it's not an architecture problem .. xrootd was installed with pip in a venv (but it required ninja usage with export CMAKE_GENERATOR=Ninja)

@ktf ktf merged commit 2fe6122 into alisw:master Oct 18, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants