Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc for extra monitoring exe #5749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

grpc for extra monitoring exe #5749

wants to merge 1 commit into from

Conversation

sy-c
Copy link
Contributor

@sy-c sy-c commented Jan 29, 2025

No description provided.

@sy-c sy-c requested a review from a team as a code owner January 29, 2025 13:45
@vascobarroso vascobarroso enabled auto-merge (squash) January 29, 2025 13:49
@vascobarroso
Copy link
Contributor

@sy-c could you have a look at the error ? Looks related to the monitoring lib, although it seems to only affect SLC8.

@sy-c
Copy link
Contributor Author

sy-c commented Jan 30, 2025

I don't understand this issue, the error happens when building data distribution.
It complains about requiring Monitoring version 3, but having 1.18.0, and I don't know where this number comes from, it's not what is set in CMake. I will launch a test build on a rh8 node to see.

@sy-c
Copy link
Contributor Author

sy-c commented Jan 30, 2025

I can reproduce it on a test machine... trying to debug.

@sy-c
Copy link
Contributor Author

sy-c commented Jan 30, 2025

The problem looks to be related to DataDistribution/CMakeLists.txt
https://github.com/AliceO2Group/DataDistribution/blob/4ff6e1669c96f2688ef8a433aaddb037b44bdf5a/CMakeLists.txt#L118

the error appears with:
find_package(Monitoring 3 REQUIRED) # AliceO2::Monitoring

CMake Error at CMakeLists.txt:118 (find_package):
Could not find a configuration file for package "Monitoring" that is
compatible with requested version "3".

The following configuration files were considered but not accepted:

/home/alibuild/test/sw/slc8_x86-64/Monitoring/dev-local1/lib/cmake/Monitoring/MonitoringConfig.cmake, version: 1.18.0

I have no clue why it reports version "1.18.0", this file states "3.18.2"
(1.18.0 is the FLPsuite version ?)

When removing the "3" requirement:
find_package(Monitoring REQUIRED) # AliceO2::Monitoring

everything works as expected:

"-- Monitoring 3.18.2 found"

There were some recent changes in CMake version, could it be related ?
@ktf @lkrcal what do you think ?

@vascobarroso
Copy link
Contributor

@ktf @lkrcal could you have a look at Sylvain's comment and chip in on this ? We need this pretty soon at P2 otherwise some parts of monitoring won't work when we migrate to RHEL 9.

@ktf
Copy link
Member

ktf commented Jan 31, 2025

I suspect the problem is that it should be:

find_package(Monitoring 3 REQUIRED CONFIG)

Can you try with it?

@ktf
Copy link
Member

ktf commented Jan 31, 2025

That said, do we actually have a Monitoring v2 package we want to support? I would drop the version...

@sy-c
Copy link
Contributor Author

sy-c commented Jan 31, 2025

find_package(Monitoring 3 REQUIRED CONFIG) does not help.
Indeed, I don't think we have a v2 anywhere, and removing the "3" works.
I'll create a PR in datadistribution then.

sy-c added a commit to sy-c/DataDistribution that referenced this pull request Jan 31, 2025
The check on monitoring version fails on some systems.
cf alisw/alidist#5749
@sy-c
Copy link
Contributor Author

sy-c commented Jan 31, 2025

Changes proposed in DataDistribution.
@lkrcal can you please check and tag ?
AliceO2Group/DataDistribution#186

lkrcal pushed a commit to AliceO2Group/DataDistribution that referenced this pull request Feb 7, 2025
The check on monitoring version fails on some systems.
cf alisw/alidist#5749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants