Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor credentials providers #963

Merged
merged 1 commit into from
Dec 3, 2024
Merged

refactor credentials providers #963

merged 1 commit into from
Dec 3, 2024

Conversation

yndu13
Copy link
Collaborator

@yndu13 yndu13 commented Dec 2, 2024

No description provided.

@yndu13 yndu13 requested a review from xiahuai as a code owner December 2, 2024 13:39
@yndu13 yndu13 force-pushed the imds branch 6 times, most recently from 5c0dede to 3589864 Compare December 3, 2024 03:55
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 91.53543% with 43 lines in your changes missing coverage. Please review.

Project coverage is 90.65%. Comparing base (f8e6e72) to head (9c6a914).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...m/aliyuncs/auth/CLIProfileCredentialsProvider.java 88.79% 4 Missing and 9 partials ⚠️
...java/com/aliyuncs/auth/URLCredentialsProvider.java 77.35% 9 Missing and 3 partials ⚠️
...re/src/main/java/com/aliyuncs/utils/AuthUtils.java 86.44% 4 Missing and 4 partials ⚠️
...ncs/auth/ECSMetadataServiceCredentialsFetcher.java 91.48% 2 Missing and 2 partials ⚠️
...ava/com/aliyuncs/auth/OIDCCredentialsProvider.java 96.66% 0 Missing and 2 partials ⚠️
.../auth/STSAssumeRoleSessionCredentialsProvider.java 97.22% 0 Missing and 2 partials ⚠️
.../com/aliyuncs/auth/DefaultCredentialsProvider.java 97.43% 0 Missing and 1 partial ⚠️
...yuncs/auth/InstanceProfileCredentialsProvider.java 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #963      +/-   ##
============================================
+ Coverage     90.17%   90.65%   +0.47%     
- Complexity     1676     1803     +127     
============================================
  Files           124      126       +2     
  Lines          4826     5287     +461     
  Branches        552      627      +75     
============================================
+ Hits           4352     4793     +441     
- Misses          345      349       +4     
- Partials        129      145      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yndu13 yndu13 force-pushed the imds branch 2 times, most recently from 6d9e170 to 4e7e95f Compare December 3, 2024 05:14
@yndu13 yndu13 merged commit 10fa20d into master Dec 3, 2024
2 of 4 checks passed
@yndu13 yndu13 deleted the imds branch December 3, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants