[risk=low][no ticket] Renaming of free tier in many locations #9092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthibault79
force-pushed
the
joel/exhaustion
branch
from
5b91eb7 to
d70d699
Compare
jmthibault79
changed the title
jmthibault79
force-pushed
the
joel/exhaustion
branch
from
d70d699 to
86e85cc
Compare
jmthibault79
changed the title
jmthibault79
force-pushed
the
joel/exhaustion
branch
2 times, most recently
from
ce89215 to
4e22c38
Compare
jmthibault79
commented
Feb 7, 2025
| @@ -1,14 +1,14 @@ | |||
| package org.pmiops.workbench.initialcredits; | |||
| package org.pmiops.workbench.utils; | |||
There was a problem hiding this comment.
these can be useful more generally
12 tasks
jmthibault79
force-pushed
the
joel/exhaustion
branch
from
0aaf3b3 to
d5f2592
Compare
jmthibault79
changed the title
jmthibault79
force-pushed
the
joel/exhaustion
branch
from
d5f2592 to
b4313ed
Compare
jmthibault79
force-pushed
the
joel/exhaustion
branch
from
b4313ed to
4ee1fe4
Compare
jmthibault79
commented
Feb 27, 2025
| * 1- Get users who have active free tier workspaces 2- Iterate over these users in batches of X | ||
| * and find the cost of their workspaces before/after | ||
| */ | ||
| public void checkInitialCreditsUsage() { |
There was a problem hiding this comment.
unused! I assume this was replaced by checkInitialCreditsUsage(List<Long> userIdList) at some point, which is still in use.
| @@ -136,20 +91,4 @@ public Map<String, Double> getFreeTierWorkspaceCostsFromBQ() { | |||
|
|
|||
| return liveCostByWorkspace; | |||
| } | |||
|
|
|||
| private int freeTierCronUserBatchSizeFromConfig() { | |||
|
|
||
| // TODO updateCost queries for each workspace, can be optimized by getting all needed workspaces |
There was a problem hiding this comment.
not a new comment; just moved up slightly
| @@ -404,13 +404,13 @@ public void listBillingAccounts_upgradeYES_freeYES_cloudYES() throws IOException | |||
| assertThat(response.getBillingAccounts()).isEqualTo(expectedWorkbenchBillingAccounts); | |||
| } | |||
|
|
|||
| // billing upgrade is true, free tier is available, no cloud accounts | |||
There was a problem hiding this comment.
"billing upgrade" is an old feature flag. It's always true now. It means that it's possible for users to provide their own billing.
jmthibault79
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR renaming "free tier" and "free credits" to "initial credits" where appropriate.
This PR is not intended to be comprehensive. Some references to Free Tier remain.
PR checklist
[risk=no|low|moderate|severe]in the PR title as outlined in CONTRIBUTING.md.