Joel/vo records #9110
Draft
Joel/vo records #9110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthibault79
force-pushed
the
joel/vo-records
branch
from
ab38a0f to
62bcbe8
Compare
jmthibault79
commented
Feb 12, 2025
| @@ -562,7 +562,8 @@ public int hashCode() { | |||
| wgsLongReadsJointVcfGRCh38, | |||
| wgsLongReadsJointVcfT2T, | |||
| publicReleaseNumber, | |||
| vwbTemplateId); | |||
| vwbTemplateId, | |||
| publicReleaseNumber); | |||
| @@ -587,10 +588,10 @@ public boolean equals(Object o) { | |||
| && Objects.equals(wgsBigqueryDataset, that.wgsBigqueryDataset) | |||
| && Objects.equals(wgsFilterSetName, that.wgsFilterSetName) | |||
| && Objects.equals(hasFitbitData, that.hasFitbitData) | |||
| && Objects.equals(hasCopeSurveyData, that.hasCopeSurveyData) | |||
There was a problem hiding this comment.
moved to use the ordering we have elsewhere
|
|
||
| // used for JSON parsing of cdr_config_*.json | ||
| // adapted from DbAccessTier | ||
| public record AccessTierConfig( |
There was a problem hiding this comment.
convert these from "Value Objects" to records, which enforce that all fields are considered on creation - though they can be null
| @Mapper( | ||
| config = MapStructConfig.class, | ||
| uses = {CommonMappers.class, DbStorageEnums.class}) | ||
| public interface CdrConfigMapper { |
There was a problem hiding this comment.
this was CdrConfigVOMapper
| @Mapping(source = "accessTier", target = "accessTier", qualifiedByName = "toDbTierByShortName") | ||
| DbCdrVersion toDbVersion(CdrVersionConfig localVersion, @Context AccessTierDao accessTierDao); | ||
|
|
||
| @Named("toDbTierByShortName") |
There was a problem hiding this comment.
this was an @AfterMapper in the previous version. I think this is clearer.
| hasFitbitData, | ||
| hasCopeSurveyData, | ||
| hasFitbitSleepData, | ||
| null, |
There was a problem hiding this comment.
TODO. we were missing a lot of newer params in this test.
Not adding them here, to demonstrate that this is just a translation of the original and also to show that these can be null. I'll come back for this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
[risk=no|low|moderate|severe]in the PR title as outlined in CONTRIBUTING.md.