Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deogierize consul #195

Closed
wants to merge 5 commits into from
Closed

Deogierize consul #195

wants to merge 5 commits into from

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Mar 3, 2017

Adresses #193

Mateusz Gajewski added 2 commits March 3, 2017 12:36
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.608% when pulling 22ca157 on remove_ogier into bb2478e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.608% when pulling cb850c1 on remove_ogier into bb2478e on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 90.731% when pulling 859ef8c on remove_ogier into 329d53a on master.

@janisz
Copy link
Contributor

janisz commented Mar 6, 2017

Since this change breaks backward compatibility, it should wait for version 1.3.0 or should be merged to develop.

@guilhem guilhem mentioned this pull request Mar 6, 2017
Open
janisz
janisz suggested changes Mar 6, 2017
View reviewed changes
Copy link
Contributor

@janisz janisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold it until we agree on some solution on #193 (comment)

@wendigo
Copy link
Contributor Author

wendigo commented Mar 6, 2017

Sure thing @janisz

@janisz
Copy link
Contributor

janisz commented May 30, 2017

Closing due to missing backward compatibility.

@janisz janisz closed this May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janisz janisz janisz requested changes

@dankraw dankraw dankraw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendigo @coveralls @janisz @dankraw @adamdubiel