Cache items fetched during the request in memory #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottnelle
approved these changes
Nov 8, 2024
| $value = $this->cache[ $group ][ $key ]; | ||
|
|
||
| if ( is_object( $value ) ) { | ||
| $value = clone $value; |
There was a problem hiding this comment.
I gather that this is an established pattern when accessing objects from an array, but I wouldn't mind a comment here as to why so it's clear to future readers that you didn't intend to assign this clone to a new variable.
There was a problem hiding this comment.
Good call. I added a comment. It's not about the array, rather about not reusing the object instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a nod towards #7, although not as flexible or comprehensive as that issue envisions.