Enable local site-search and support for lowercasing searches #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for submitting this! Question, would you be able to add the ability for the user to specify the query param? It would make this a lot more flexible. |
|
Good idea, working on it! |
|
Updated version @allinurl but not entirely sure I'm taking the best approach to save the param variations in config options (really I need to add two more as well to handle encoded). Any better option ? |
allinurl
force-pushed
the
master
branch
2 times, most recently
from
0550432
to
b1332f5
Compare
allinurl
force-pushed
the
master
branch
5 times, most recently
from
3d5333b
to
6c68a6e
Compare
allinurl
force-pushed
the
master
branch
7 times, most recently
from
31e2ac1
to
c6199f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A rough start at supporting local site searches (ala #96 for other search engines) , that are making use of the same query param ('q') as Google search.
Not sure if would be better as a new output instead of overriding the Google table ?
Have also added downcasing of the search term which sometimes makes results more useful for us. This might be a niche concern.