Dummy PR to compare miniaudio2 to upstream's dev #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so that it’s possible to override embedded game
.. at least this is is how I think you export symbols on windows properly :S
With the check for samples==0 being done BELOW the assert for offset+samples<soundData->samples, setting samples to 0 and then having more samples available in the mic than present in the created buffer would cause buffer overrun
This reverts commit faa65dc. I can't get it to build in Windows :(
again manually fixing our filesystem override to prioritize cli arg
Neither Quest nor Pico check for null on its out-params. Better to send in dummy params to avoid nulls.
Otherwise controllers are backwards with OpenVR :S
This makes it possible to reverse a lovr-mouse click on the mirror window into worldspace in pure Lua
with a pcall, like the requires above. so if there is no matching headset driver, the module is just turned off.
…ewports()" This reverts commit 0353e85.
To be consistent with the pose for controllers.
* Takes device type, so you only get either playback or capture devices * Doesn't store devices in state, reducing risk of dangling pointers * Uses names instead of identifiers, since miniaudio identifiers become invalid if you call "getDevices" again * Better diagnostics * Split up lovrAudioInitDevice to be per-type, cleaner that way * UseDevice now takes type and name, instead of just identifier
* Stop also uninitializes
* Reset doesn't exist. Just stop and start instead.
* lovrAudioInit no longer takes config, and config is now private.
Call lovrAudioStart if you want to start.
* ma_device_{un}init and start/stop are only called from one place each,
reducing the risk of dangling state
instead of mixing up using device with using format
in case initing a device is expensive, don't do it unnecessarily, and treat 'stop' as more of a 'pause'.
why is this so hard for my brain? :S
Miniaudio devices
it's a quat, not an axis-angle. now it works :)
so that app can know focus on app start
- Reduce epsilon - Also use epsilon in D_GGX - Reduce shader string length to the minimum required supported length
nevyn
commented
Apr 6, 2021
| @@ -18,6 +18,7 @@ StringEntry lovrEventType[] = { | |||
| #ifdef LOVR_ENABLE_THREAD | |||
| [EVENT_THREAD_ERROR] = ENTRY("threaderror"), | |||
| #endif | |||
| [EVENT_PERMISSION] = ENTRY("permission"), | |||
There was a problem hiding this comment.
Task: Audio permission event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.