Feat: Declared EthBlockBody trait
#2085
Open
+21
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PoulavBhowmick03
requested review from
DaniPopes,
gakonst,
mattsse,
onbjerg and
klkvr
as code owners
mattsse
reviewed
Feb 19, 2025
crates/consensus/src/block/traits.rs
Outdated
| @@ -12,3 +12,21 @@ impl<T, H> EthBlock for Block<T, H> { | |||
| self.body.withdrawals.as_ref() | |||
| } | |||
| } | |||
|
|
|||
| /// A trait for Ethereum block body utilities. | |||
| pub trait BlockBodyTrait { | |||
There was a problem hiding this comment.
can we name this EthBlockBody perhaps?
PoulavBhowmick03
force-pushed
the
declare_blockbody_trait
branch
from
c637434 to
5caf004
Compare
PoulavBhowmick03
changed the title
BlockBody traitEthBlockBody trait
yash-atreya
added
c-consensus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2083
Solution
Added a
BlockBodyTraitin crates/consensus/src/block/traits.rs and it's implementations and then imported it incrates/consensus/src/block/mod.rsandcrates/consensus/src/lib.rsI have not implemented the transaction associated type, after reading the comment in the issue page
All the tests pass
PR Checklist