Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): Batch TX Data #195

Merged
merged 7 commits into from
Oct 29, 2024
Merged

feat(protocol): Batch TX Data #195

merged 7 commits into from
Oct 29, 2024
+393 −2

Conversation

refcell
Copy link
Collaborator

@refcell refcell commented Oct 28, 2024 •
edited
Loading

Description

Ports the batch transaction data types to op-alloy-protocol.

Provenance

Part of a port migrating the batch types from kona-derive to op-alloy. See kona#695.

This was referenced Oct 28, 2024
Merged
Merged
@refcell
Copy link
Collaborator Author

refcell commented Oct 28, 2024 •
edited
Loading

📚 $\text{Stack Overview}$

Pulls submitted in this stack:

This comment was automatically generated by st.

This was referenced Oct 28, 2024
Closed
Merged
Merged
@refcell refcell self-assigned this Oct 28, 2024
@refcell refcell added the A-protocol Area: protocol crate label Oct 28, 2024
This was referenced Oct 28, 2024
Merged
Merged
@refcell refcell force-pushed the rf/feat/bits branch 2 times, most recently from e042e6c to e950702 Compare October 28, 2024 13:43
Base automatically changed from rf/feat/bits to main October 28, 2024 23:35
clabby
clabby requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@clabby clabby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these transactions' to_enveloped_tx functions, can we use OpTxEnvelope?

Notably all transactions within span batches are L2 txs, even if the interior types are "equivalent."

Otherwise, this lgtm.

@refcell refcell requested a review from clabby October 29, 2024 15:41
@refcell refcell added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit f395b35 Oct 29, 2024
19 checks passed
@refcell refcell deleted the rf/feat/tx-data branch October 29, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clabby clabby clabby approved these changes

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees

@refcell refcell

Labels
A-protocol Area: protocol crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@refcell @clabby