feat: OpTransactionRequest
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
requested review from
mattsse,
emhane,
refcell and
clabby
as code owners
mattsse
approved these changes
Nov 1, 2024
3 tasks
|
Removing op-alloy-rpc-types crate from no-std checks, will re-add in #205 which will have alloy-rs/alloy#1602 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #27
To be able to replace
UnsingedTxandTxEnvelopeon Optimism network with op-consensus types, we need a op-specific tx builder.Solution
Add
OpTransactionBuilderwhich is a wrapper aroundTransactionBuilder. It intentionally does not have any direct methods allowing to set EIP-4844 fields, however they can still be set throughAsMutor during deserialization.When building typed transaction, eip-4844 transactions are getting converted to eip-1559
PR Checklist