Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error notification when user try to use mocha reporter in paralle… #620

Merged
merged 4 commits into from
Mar 1, 2023

Conversation

epszaw
Copy link
Member

@epszaw epszaw commented Feb 20, 2023

Context

Add runtime error to prevent using the mocha reporter in parallel mode

Checklist

@epszaw epszaw added type:bug Something isn't working theme:mocha Mocha related issue labels Feb 20, 2023
@epszaw epszaw requested a review from vovsemenv February 20, 2023 16:30
@epszaw epszaw requested a review from baev February 22, 2023 13:18
Copy link
Collaborator

@vovsemenv vovsemenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add tests to check thar behavior?

@epszaw
Copy link
Member Author

epszaw commented Feb 22, 2023

is it possible to add tests to check thar behavior?

I think, no, cuz we don't have access to spy anything in parallel thread

@epszaw epszaw requested a review from vovsemenv February 22, 2023 14:29
@epszaw epszaw force-pushed the mocha-parallel-mode-error branch from d570b1c to e72d509 Compare February 27, 2023 14:10
Copy link
Collaborator

@vovsemenv vovsemenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be fine

@epszaw epszaw self-assigned this Feb 28, 2023
@baev baev merged commit 091f81e into master Mar 1, 2023
@baev baev deleted the mocha-parallel-mode-error branch March 1, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:mocha Mocha related issue type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants