Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reactive implementation #8

Merged
merged 4 commits into from
Mar 8, 2016
Merged

Conversation

fabb
Copy link
Collaborator

@fabb fabb commented Feb 29, 2016

@fabb fabb assigned fabb and almostintuitive and unassigned fabb Feb 29, 2016
@fabb
Copy link
Collaborator Author

fabb commented Mar 3, 2016

@itchingpixels: what do you think?

@almostintuitive
Copy link
Owner

sorry, I'll have time to look today!:)

@almostintuitive
Copy link
Owner

really nice, thank you!

I've pushed some code to this branch:
78f39dc fixed_reactive_implementation-ver-2

I've tweaked a little bit on these:

  • we could get rid of the optional in Variable<UIGestureRecognizerType?> if the init requirements are rearranged
  • instead of returning new Observable from combineLatest, you can just return a value, that makes it slightly more simple.
  • using filter operator on the signal level instead of guard in the subscribeNext block

I have been thinking and I haven't found any other straightforward way to filter out multiple began events than to combine the .Began and .Ended signals as you did (then using distinctUntilChanged), that was a nice solution!

what do you think?

@almostintuitive
Copy link
Owner

I've just updated the commit hash in the last message

@fabb
Copy link
Collaborator Author

fabb commented Mar 8, 2016

@itchingpixels I'd say we merge this PR, and create another one for your changes. The other branch has quite many broken unit tests that still would need to be resolved.

fabb added a commit that referenced this pull request Mar 8, 2016
@fabb fabb merged commit 5b39539 into master Mar 8, 2016
@fabb fabb deleted the fixed_reactive_implementation branch March 8, 2016 07:33
@almostintuitive
Copy link
Owner

cool, cheers. I've made some last minute changes because previously all unit tests were passing but the actual demo didn't work as expected, and it seems like I forgot to run the tests again after :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactive Controller doesn't 'reset'
2 participants