-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed reactive implementation #8
Conversation
…uld end, when EITHER of the gestures end, NOT when BOTH end
…, just like the imperative version
@itchingpixels: what do you think? |
sorry, I'll have time to look today!:) |
really nice, thank you! I've pushed some code to this branch: I've tweaked a little bit on these:
I have been thinking and I haven't found any other straightforward way to filter out multiple began events than to combine the .Began and .Ended signals as you did (then using distinctUntilChanged), that was a nice solution! what do you think? |
I've just updated the commit hash in the last message |
@itchingpixels I'd say we merge this PR, and create another one for your changes. The other branch has quite many broken unit tests that still would need to be resolved. |
cool, cheers. I've made some last minute changes because previously all unit tests were passing but the actual demo didn't work as expected, and it seems like I forgot to run the tests again after :( |
XCTAssertNil(mockTimer)
for now)