Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug info for SYCL zero-dim buffer alloc #2127

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

bernhardmgruber
Copy link
Member

@bernhardmgruber bernhardmgruber commented Sep 5, 2023

This fixes a compilation error with the SYCL backend in debug mode.

I also made make_sycl_range and make_sycl_offset support zero-dimensional extents, but this may be unrelated to the issue at hand.

Fixes: #2124

This fixes a compilation error with the SYCL backend in debug mode.

Fixes: alpaka-group#2124
@bernhardmgruber
Copy link
Member Author

@SimeonEhrig the compilation failure that I am fixing here happens when you build with -DCMAKE_BUILD_TYPE=Debug and
-Dalpaka_DEBUG=2. Do we have any CI runs that also test various alpaka debug levels?

@bernhardmgruber bernhardmgruber marked this pull request as ready for review September 5, 2023 10:13
@SimeonEhrig
Copy link
Member

@SimeonEhrig the compilation failure that I am fixing here happens when you build with -DCMAKE_BUILD_TYPE=Debug and -Dalpaka_DEBUG=2. Do we have any CI runs that also test various alpaka debug levels?

There is one clang analysis job, who uses alpaka_DEBUG=2. The rest uses alpaka_DEBUG=0

https://gitlab.com/hzdr/crp/alpaka/-/jobs/5019152381

@bernhardmgruber
Copy link
Member Author

@SimeonEhrig the compilation failure that I am fixing here happens when you build with -DCMAKE_BUILD_TYPE=Debug and -Dalpaka_DEBUG=2. Do we have any CI runs that also test various alpaka debug levels?

There is one clang analysis job, who uses alpaka_DEBUG=2. The rest uses alpaka_DEBUG=0

https://gitlab.com/hzdr/crp/alpaka/-/jobs/5019152381

Alright, thx! I think we should also have CI jobs that run with alpaka_DEBUG=2. I opened an issue for that: #2130

@AuroraPerego
Copy link
Contributor

memBufTest now passes on the Intel GPU :)

@j-stephan j-stephan merged commit 6b43b8d into alpaka-group:develop Sep 5, 2023
19 checks passed
@bernhardmgruber bernhardmgruber deleted the fix_sycl_dim0 branch September 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

develop branch broken on oneAPI
4 participants