Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use content_id for matching list items #2224

Draft
wants to merge 1 commit into
base: 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l
Choose a base branch
from

Conversation

unoduetre
Copy link
Contributor

@unoduetre unoduetre commented Jul 25, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

Use content_id instead of base_path for matching list items. This fixes the following bug. A video showing the bug is attached to the Trello card.

Reported by Polly Green in the Yellow team https://gds.slack.com/archives/CACV3TACU/p1689250423550889 and I’ve just tested the following on integration:

  1. Go to a curated section of mainstream browse, for example
    https://www.integration.publishing.service.gov.uk/browse/childcare-parenting/schools-education
  2. Choose one content page in the list and change the slug for it
  3. Publish the slug change for the content item
  4. Check browse page and content item with the new slug still appears in the list.
  5. I then removed another page from the same list, under the same subheading as the content item that had the slug change. Removing the other content item, also removes the content item that had the slug changed.
  6. But the content item that had the slug change still appears in collections publisher under the same heading, but does not show on the front end anymore.

Why

Trello ticket

Dependencies

This PR depends on merging #2223 first and applying the rake task.

@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from f93782b to 7e1a7dd Compare July 25, 2024 15:48
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l-2 branch from a9b6b8e to 115c9fb Compare July 25, 2024 15:51
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from 7e1a7dd to a280838 Compare July 26, 2024 08:21
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l-2 branch from 115c9fb to f2dfdc5 Compare July 26, 2024 08:22
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from a280838 to a63c7bf Compare July 26, 2024 09:05
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l-2 branch from f2dfdc5 to 1e404f5 Compare July 26, 2024 09:06
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from a63c7bf to 5204e9a Compare July 26, 2024 09:27
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l-2 branch from 1e404f5 to 1f2ebd3 Compare July 26, 2024 09:28
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l branch from 5204e9a to 7830553 Compare July 26, 2024 13:31
@unoduetre unoduetre force-pushed the 2733-bug-curated-mainstream-browse-doesnt-show-content-following-a-slug-change-and-update-to-the-page-curation-l-2 branch from 1f2ebd3 to cf52aee Compare July 26, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant