Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the links on Styles section #4306

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Update the links on Styles section #4306

merged 1 commit into from
Nov 18, 2024

Conversation

calvin-lau-sig7
Copy link
Contributor

What

Changes identified unclear links on the homepage, root pages and Get Started sections

Why

This more clearly communicates what the link is and where it goes to. Part of #4267.
Note that these changes have mostly been pre-reviewed via our link audit worksheet.

Copy link

netlify bot commented Nov 15, 2024

You can preview this change here:

Name Link
🔨 Latest commit 23d6901
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/673781c4870e2b0008f93519
😎 Deploy Preview https://deploy-preview-4306--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content all looking good. Before I approve I have a single pithy comment that I'd like us to have a clearer commit message than just 'input link edits'. We could separate by page here but a single commit outlining the way this change is categorised also works.

@calvin-lau-sig7
Copy link
Contributor Author

Hooray! Of course, I've squashed and committed as:

Input link text edits for 'Styles' section from worksheet

@owenatgov owenatgov self-requested a review November 15, 2024 17:18
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏻

@calvin-lau-sig7 calvin-lau-sig7 merged commit 63dc517 into main Nov 18, 2024
15 checks passed
@calvin-lau-sig7 calvin-lau-sig7 deleted the edit-link-styles branch November 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants