Update sub-table link text in nunjucks macros #4309
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ You can preview this change here:
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-Authored-By: Calvin Lau <[email protected]>
owenatgov
force-pushed
the
nunjucks-macro-link-text
branch
from
0618095
to
b29aa47
Compare
calvin-lau-sig7
approved these changes
Nov 18, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates the link text for the generated links in our examples partial, where a nunjucks macro option has it's own params and the link jumps to that option's own option table.
Why
Part of #4267. This change will resolve 64 identified links that need clearer link text.
Notes
The first variation on line 120, which is used when a sub option is referencing a component that isn't the hint or label "components", doesn't have any instances across our library. This makes it hard to test. I was able to hard code it appearing by removing the label and hint condition. See the below screen shot of an example from the Text input options: