Remove unnecessary comment #2080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The link 404s as the file has been deleted - so we'd probably want to link to a previous commit version instead: https://github.com/alphagov/whitehall/blob/942744666bd6eabac4f552baa082a44659d5a749/script/scrub-database But that commit is 10 years old and the reason the file was deleted is that the contents were ported over to https://github.com/alphagov/govuk-puppet/blob/main/modules/govuk_env_sync/files/transformation_sql/sanitise_whitehall.sql, which would probably be a better place to link to. But then there's little value in linking to the govuk-puppet equivalent of all the new infrastructure. Suggest we just bin this.
richardTowers
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link 404s as the file has been deleted - so we'd probably want to link to a previous commit version instead:
https://github.com/alphagov/whitehall/blob/942744666bd6eabac4f552baa082a44659d5a749/script/scrub-database
But that commit is 10 years old and the reason the file was deleted is that the contents were ported over to
https://github.com/alphagov/govuk-puppet/blob/main/modules/govuk_env_sync/files/transformation_sql/sanitise_whitehall.sql, which would probably be a better place to link to.
But then there's little value in linking to the govuk-puppet equivalent of all the new infrastructure. Suggest we just bin this.