-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add report CI errors github action #1729
base: main
Are you sure you want to change the base?
Conversation
name: Always failing job | ||
on: | ||
workflow_dispatch: | ||
|
||
jobs: | ||
failed-run: | ||
name: Failed run | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- name: Always failing | ||
run: exit 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use a real use case example here like name: Deploy
. This is how the workflow can be tested so might be a bit confusing/unhelpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code here is just for showing where the code is inserted and used rather than being a demonstration of a use case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a note to state where the action might be typically used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks good.
I left a few comments. I’d give it more general name and message. We should try to scope it to main branch.
@@ -0,0 +1,26 @@ | |||
## Pre-requisites | |||
|
|||
You will need to get the slack webhook url from the secrets manager first and add it as SLACK_WEBHOOK_URL as a repository secret. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to move away from ClickOpsing GitHub config so ideally it should be added in the Terraform config. Similar to organisations secrets https://github.com/alphagov/govuk-infrastructure/blob/main/terraform/deployments/github/main.tf#L224-L253
As per our chat on Slack: https://gds.slack.com/archives/C079ULB1UEP/p1740663568473939
Add a custom github action to make it easier to send CI errors to a team channel with some notes on how to use the action.