PP-12427 switch to worldpay (MOTO service) impl #4458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlsteers
force-pushed
the
pp-12427/moto-switch-to-worldpay
branch
2 times, most recently
from
cdf7e5a to
3d8c88f
Compare
- new views and controllers for handling switch to worldpay tasks for a moto service - new `ChargeRequest` class - new `GatewayAccountSwitchPaymentProviderRequest` class - extend `WorldpayTasks`: add `makeALivePayment` (verify that worldpay credentials are working) - update `GatewayAccountCredentialUpdateRequest`, enable credential state change - extract one off customer initiated credentials validation into reusable schema
nlsteers
force-pushed
the
pp-12427/moto-switch-to-worldpay
branch
from
3d8c88f to
737de20
Compare
DomBelcher
reviewed
Feb 18, 2025
| */ | ||
| constructor (gatewayAccount, serviceExternalId) { | ||
| constructor (gatewayAccount, serviceExternalId, switchingPsp = false) { |
There was a problem hiding this comment.
i wonder whether there should be a static WorldpayTasks.forSwitchingPsp method instead of a constructor with various options
Comment on lines
+56
to
+67
| chargeService.getCharge(service.externalId, account.type, chargeExternalId) | ||
| .then(async (charge) => { | ||
| if (charge.state.status === 'success') { | ||
| await worldpayDetailsService.updateCredentialState(service.externalId, account.type, targetCredential.externalId, user.externalId, CREDENTIAL_STATE.VERIFIED) | ||
| req.flash('messages', { state: 'success', icon: '✓', heading: 'Payment verified', body: `This service is ready to switch to ${formatPSPName(targetCredential.paymentProvider)}` }) | ||
| } else { | ||
| req.flash('messages', { state: 'error', heading: 'There is a problem', body: 'The payment has failed. Check your Worldpay credentials and try again. If you need help, contact [email protected]' }) | ||
| } | ||
| res.redirect(formatSimplifiedAccountPathsFor(paths.simplifiedAccount.settings.switchPsp.switchToWorldpay.index, | ||
| service.externalId, account.type)) | ||
| }) | ||
| .catch(err => next(err)) |
There was a problem hiding this comment.
this might be neater without the promise/then and just using async/await like
const charge = await chargeService.getCharge(...)
if (charge.state.status !== 'success') {
// return error
}
await worldpayDetailsService.updateCredentialState(...)
// return successmay need a try/catch to be sure errors are handled properly
There was a problem hiding this comment.
I'll experiment with the structure here once I have a cypress test for this controller
...s/simplified-account/settings/switch-psp/switch-to-worldpay/switch-to-worldpay.controller.js
Outdated
Show resolved
Hide resolved
nlsteers
force-pushed
the
pp-12427/moto-switch-to-worldpay
branch
from
e94d6f9 to
5be728f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
ChargeRequestclassGatewayAccountSwitchPaymentProviderRequestclassWorldpayTasks: addmakeALivePayment(verify that worldpay credentials are working)GatewayAccountCredentialUpdateRequest, enable credential state changeHOW
this PR requires a corresponding change in connector in order to behave correctly
additionally, our stubbing mechanism for worldpay orders does not account for how we currently handle moto services.
in production a gateway account will have a MOTO specific merchant code that worldpay will recognise and determine not to request a 3DS check.
our stubbing mechanism is not that smart (because connector still includes the flag to request 3DS regardless of MOTO status). you will need to manually change the gateway account
requires3dsflag to false in order to test locally if using stubs to mock out worldpay responsesSCREENS