Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP-12427 unit test switch psp controllers #4470

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

nlsteers
Copy link
Collaborator

@nlsteers nlsteers commented Feb 19, 2025

WHAT

  • switch to worldpay (switch psp) controller unit tests
  • prevent tasks from being accessed out of sequence
    • update TaskAccessedOutOfSequenceError to handle redirect if provided
  • add default session object to ControllerTestBuilder req
  • update stripe task middleware checker to provide a redirect to TaskAccessedOutOfSequenceError

@nlsteers nlsteers force-pushed the pp-12427/moto-switch-to-worldpay-tests branch 3 times, most recently from 3cad19b to 68fab55 Compare February 19, 2025 19:22
- switch to worldpay (switch psp) controller unit tests
- prevent tasks from being accessed out of sequence
  - update `TaskAccessedOutOfSequenceError` to handle redirect if provided
- add default session object to `ControllerTestBuilder` req
- update stripe task middleware checker to provide a redirect to `TaskAccessedOutOfSequenceError`
@nlsteers nlsteers force-pushed the pp-12427/moto-switch-to-worldpay-tests branch from 68fab55 to eb013b4 Compare February 19, 2025 19:27
@nlsteers nlsteers changed the title [WIP] unit test worldpay switch index controller PP-12427 unit test switch psp controllers Feb 19, 2025
@nlsteers nlsteers marked this pull request as ready for review February 19, 2025 19:27
Copy link
Contributor

@james-peacock-gds james-peacock-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nlsteers nlsteers merged commit 5264e74 into master Feb 20, 2025
14 checks passed
@nlsteers nlsteers deleted the pp-12427/moto-switch-to-worldpay-tests branch February 20, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants