497 use updated add another component #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaylorgds
reviewed
Jan 28, 2025
| end | ||
| end | ||
|
|
||
| should "display 'Delete' buttons and a second set of inputs when 'Add another link' is clicked" do | ||
| click_button("Add another link") | ||
| should "display a 'Delete' button and a set of inputs when 'Add another link' is clicked" do |
There was a problem hiding this comment.
We should update the test name
Suggested change
| should "display a 'Delete' button and a set of inputs when 'Add another link' is clicked" do | |
| should "display a 'Delete' button and a set of inputs when 'Add related external link' is clicked" do |
(or, to ease future maintenance burden, don't quote it exactly and just do "display a 'Delete' button and a set of inputs when the add button is clicked")
(We should also ensure all the tests have consistent terminology if we change it.)
| assert page.has_css?("button", text: "Delete") | ||
| end | ||
| end | ||
|
|
||
| should "delete the first set of fields when the user clicks the first “Delete” button" do | ||
| click_button("Add another link") | ||
| should "delete the set of fields when the user clicks the “Delete” button" do |
There was a problem hiding this comment.
We should be consistent when we're quoting the button text—always use single quotes, or always use double quotes.
- Update `Gemfile.lock` for v.51.0.0 of govuk_publishing_components gem - Update partial to use updated component - Update button text - Update tests for updated UI
davidtrussler
force-pushed
the
497_Use-updated-Add-another-component
branch
from
f4e599f to
35b3f61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello
The changes here implement the latest release of the Publishing Components gem (version 51.0.0) that contains the configuration option added to the "Add another" component that allows its use on Mainstream as required. This adds the parameter
empty_fieldsto the component, which, when set to "true" ensures that no form fields are displayed when the component loads if no content is specified. Additionally these changes update the tests for the changed UI.They also update the button text from "Add another link" to "Add related external link".
The primary differences between this implementation and the current one are shown in the screenshots below.