Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rspec to v3.12.0 & Jasmine to v3.99.0 #341

Closed
wants to merge 2 commits into from
Closed

Update Rspec to v3.12.0 & Jasmine to v3.99.0 #341

wants to merge 2 commits into from

Conversation

huwd
Copy link
Member

@huwd huwd commented Jan 26, 2024

What’s changed

Update rspec, minor version bump only

Identifying a user need

We need to keep our dependencies up to date, or this repo should be archived

@huwd huwd changed the title Update Rspec to v3.12.0 Update Rspec to v3.12.0 & Jasmine to v3.99.0 Jan 26, 2024
@huwd
Copy link
Member Author

huwd commented Jan 26, 2024

Note Jasmine gem is End of Life.

The Jasmine Ruby gems are deprecated. There will be no further releases after                                                                                                                 
the end of the Jasmine 3.x series. We recommend that most users migrate to the                                                                                                                
jasmine-browser-runner npm package, which is the direct replacement for the                                                                                                                   
jasmine gem. See <https://jasmine.github.io/setup/browser.html> for setup                                                                                                                     
instructions, including for Rails applications that use either Sprockets or                                                                                                                   
Webpacker.                                                                                                                                                                                    
                                                                                                                                                                                              
If jasmine-browser-runner doesn't meet your needs, one of these might:                                                                                                                        
                                                                                                                                                                                              
* The jasmine npm package to run specs in Node.js:                                                                                                                                            
  <https://github.com/jasmine/jasmine-npm>                                                                                                                                                    
* The standalone distribution to run specs in browsers with no additional                                                                                                                     
  tools: <https://github.com/jasmine/jasmine#installation>                                                                                                                                    
* The jasmine-core npm package if all you need is the Jasmine assets:                                                                                                                         
  <https://github.com/jasmine/jasmine>. This is the direct equivalent of the                                                                                                                  
  jasmine-core Ruby gem.                                                                                                                                                                      

We should update this along with the readme. Separate PR however

@sengi
Copy link
Contributor

sengi commented May 15, 2024

Happened as part of #349 (and version constraints loosened to pin just the major, so should be less update toil in future).

@sengi sengi closed this May 15, 2024
@sengi sengi deleted the test-deps branch May 15, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants