Remove jasmine ruby gem and its requiring #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombye
force-pushed
the
remove-jasmine-ruby-gem
branch
4 times, most recently
from
549195f to
faa06ec
Compare
tombye
changed the title
tombye
force-pushed
the
remove-jasmine-ruby-gem
branch
from
faa06ec to
371df4f
Compare
This was missed from the pull request that replaced the jasmine ruby gem with the jasmine-browser-runner: #382
tombye
force-pushed
the
remove-jasmine-ruby-gem
branch
from
371df4f to
94045f5
Compare
tombye
changed the title
tombye
force-pushed
the
remove-jasmine-ruby-gem
branch
from
d5a55e5 to
ac363bd
Compare
1.3.5 introduced a change that broke activesupport (and so middleman, which uses it). It might be to do with it dropping Logger as a dependency but this is unclear. Full release notes are: https://github.com/ruby-concurrency/concurrent-ruby/releases/tag/v1.3.5 The activesupport gem fixed this in v7-0-stable of Rails: rails/rails#54264 So we're waiting for middleman to pull that version in. They have an issue for this: middleman/middleman#2788
tombye
force-pushed
the
remove-jasmine-ruby-gem
branch
from
ac363bd to
a7dc7dc
Compare
kr8n3r
approved these changes
Jan 17, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed from the pull request that
replaced the jasmine ruby gem with the
jasmine-browser-runner:
#382
Note: this locks the
concurrent-rubygem to v1.3.4 due to changes in that version breaking theactivesupportgem, and so middleman. This has been fixed in theactivesupportcode but not included on the v7.0 release track yet, from what I can tell, so we either wait for them to do that and middleman's gemspec should allow it to be picked up, or wait for middleman to change their gemspec semver range to include a higher release that does include it.