Adding a daily task to catch any potentially unpublished editions. #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baisa
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Mar 27, 2024
…y unpublished editions that were scheduled for the past. Rake task was added to the publisher here alphagov/travel-advice-publisher#1859
| end | ||
|
|
||
| it "does not publish editions scheduled for future publication" do | ||
| edition = create(:scheduled_travel_advice_edition, country_slug: country.slug) |
There was a problem hiding this comment.
Can write it as: edition = create(:scheduled_travel_advice_edition, scheduled_publication_time: 5.hours.from_now, country_slug: country.slug), as there have been some changes in the factory.
| @@ -0,0 +1,6 @@ | |||
| desc "Cronjob running daily to catch potentially unpublished editions" | |||
| task publish_scheduled_editions: :environment do | |||
There was a problem hiding this comment.
Just to follow convention, have the name of the file match the name of the task.
| @@ -0,0 +1,32 @@ | |||
| require "rake" | |||
| describe "publish_scheduled_editions", type: :rake_task do | |||
There was a problem hiding this comment.
Just to follow convention, have the name of the file match the name of the task.
lauraghiorghisor-tw
approved these changes
Mar 27, 2024
baisa
added a commit
to alphagov/govuk-helm-charts
that referenced
this pull request
Mar 28, 2024
…y unpublished editions that were scheduled for the past. Rake task was added to the publisher here alphagov/travel-advice-publisher#1859
…t were scheduled for the past. Cronjob is set up in govuk-helm-charts.
baisa
force-pushed
the
cronjob-to-publish-missed-scheduled-editions
branch
from
9568b4d to
b0bc432
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
Cronjob is set up in govuk-helm-charts. alphagov/govuk-helm-charts#1926