Fix Part validation behaviour after upgrading Mongo version #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The validations for parts weren't being triggered when parent model (edition) is validated. To get around this we added an explicit custom validation method to enforce the association validation. The issue that was happening was that only the first part validation message was being shown on the front end instead of everything whenever Parts were created in the old way outlined above. Quick fix of tests where slugs had `_` in them which are not allowed and failing validation quietly... Co-authored-by: Laura Ghiorghisor <[email protected]>
minhngocd
force-pushed
the
fix-mongo-update-validation-behaviour
branch
from
7949663 to
51ee786
Compare
lauraghiorghisor-tw
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validations for parts weren't being triggered when parent model (edition) is validated. To get around this we added an explicit custom validation method to enforce the association validation. The issue that was happening was that only the first part validation message was being shown on the front end instead of everything whenever Parts were created in the old way outlined above. Quick fix of tests where slugs had
_in them which are not allowed and failing validation quietly...Trello card