Skip to content

Commit

Permalink
Merge pull request #9907 from alphagov/replace-title-component-ash
Browse files Browse the repository at this point in the history
Replace title component with heading on two views
  • Loading branch information
AshGDS authored Feb 7, 2025
2 parents 87f64b9 + a69d010 commit e6debe4
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 8 deletions.
7 changes: 5 additions & 2 deletions app/views/admin/contact_translations/index.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,12 @@

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= render "govuk_publishing_components/components/title", {
<%= render "govuk_publishing_components/components/heading", {
text: "New translation",
context: @contact.title,
title: "New translation",
font_size: "xl",
heading_level: 1,
margin_bottom: 8,
} %>

<%= form_with url:admin_organisation_contact_translations_path(@contactable,@contact) do |form| %>
Expand Down
15 changes: 10 additions & 5 deletions app/views/admin/edition_translations/new.html.erb
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
<% content_for :page_title, "Add translation" %>

<%= render "govuk_publishing_components/components/back_link", {
href: admin_edition_path(@edition),
} %>
<% content_for :back_link do %>
<%= render "govuk_publishing_components/components/back_link", {
href: admin_edition_path(@edition),
} %>
<% end %>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= render "govuk_publishing_components/components/title", {
<%= render "govuk_publishing_components/components/heading", {
text: "Add translation",
context: @edition.title,
title: "Add translation",
font_size: "xl",
heading_level: 1,
margin_bottom: 8,
} %>

<%= form_with url: admin_edition_translations_path(@edition.id) do |form| %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/components/_select_with_search.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<%= content_tag :div, class: select_helper.css_classes, data: select_helper.data_attributes do %>
<% if is_page_heading %>
<%= tag.h1 label_tag(id, label, class: select_helper.label_classes, id: "#{id}_label"), class: "gem-c-title__text" %>
<%= tag.h1 label_tag(id, label, class: select_helper.label_classes, id: "#{id}_label"), class: "govuk-heading-xl" %>
<% else %>
<%= label_tag(id, label, class: select_helper.label_classes, id: "#{id}_label") %>
<% end %>
Expand Down

0 comments on commit e6debe4

Please sign in to comment.