Support infinite scroll #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -23,6 +23,7 @@ | |||
| "ember-cli-babel": "^6.8.0", | |||
| "ember-cli-htmlbars": "^2.0.1", | |||
| "ember-component-inbound-actions": "^1.3.0", | |||
| "ember-composable-helpers": "^2.1.0", | |||
There was a problem hiding this comment.
This should be a dev dependency since it's only used by the dummy app & tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During infinite scroll, you trigger a loadMore event when you scroll to the bottom which will add more items into your scroll content. However, the scrollbar remains the same size until you trigger another scroll event.
The resizeScrollbar function (used by recalculate and compute) currently recreates a new scrollbar and resets it to the top of the scroll content, but we do not need to do that to resize the scrollbar, we just have to call updateScrollbarAndSetupProperties
This will allow recalculate and compute to properly reset the size of the scrollbar when items re-render (see the example I added)