Merge pull request #7 from andreasindal/empty-string-issue

Fixed bug where trying to parse an empty string caused an exception to be thrown
alsterholm · Sep 18, 2016 · 5f1458f · 5f1458f
2 parents 5300f10 + 4abc18a
commit 5f1458f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/src/Parser.php b/src/Parser.php
@@ -45,6 +45,10 @@ public function __construct(Parsedown $parsedown)
      */
     public function parse($markdown)
     {
+        if (empty($markdown)) {
+            return '';
+        }
+
         if (config('markdown.xss')) {
             // Escape any XSS attempts
             $markdown = preg_replace('/(\[.*\])\(javascript:.*\)/', '$1(#)', $markdown);

diff --git a/tests/ParserTest.php b/tests/ParserTest.php
@@ -13,6 +13,14 @@ public function it_transforms_markdown_into_html()
         $this->assertEquals("<h1>Hello</h1>", $html);
     }
 
+    /** @test */
+    function it_returns_an_empty_string_when_trying_to_parse_an_empty_string()
+    {
+        $parser = new Parser(new Parsedown);
+
+        $this->assertEquals('', $parser->parse(''));
+    }
+
     /** @test */
     public function it_transforms_a_block_of_markdown_into_html()
     {