add dronecan negative rpm in reverse direction #165
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpwrules
reviewed
Jan 26, 2025
| @@ -1020,7 +1020,11 @@ static void send_ESCStatus(void) | |||
| current.count = 0; | |||
|
|
|||
| pkt.temperature = C_TO_KELVIN(degrees_celsius); | |||
| pkt.rpm = (e_rpm * 200) / eepromBuffer.motor_poles; | |||
| if (forward) { | |||
There was a problem hiding this comment.
Suggested change
| if (forward) { | |
| if (forward != eepromBuffer.dir_reversed) { |
Tested on top of #164. Reversing the direction in the ESC shouldn't reverse the sign of the RPM. The RPM sign should match the throttle sign if the motor is operating correctly.
There was a problem hiding this comment.
@tpwrules can you make a PR for this?I am not sure how the negative RPM is actually used in FC(just CW/CCW in here), maybe you PR this will be better?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add dronecan negative rpm when in reverse direction