Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use connection string in sqlite commands that expect a db file path #574

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eloff
Copy link

@eloff eloff commented Aug 25, 2024

The dump command wasn't working with my sqlite database url, which had connections params in the query string.

Some digging showed the connection string being passed in two places where a file path is expected.

This changes those two places to use the file path instead. I'm not 100% sure the way I compute will work in every case (just taking url.Opaque). It needs some tests and additional handling to make it more robust to other people's use cases, this was just sufficient to solve my problem.

If I know what other form of database urls are expected to be handled, I can add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant