Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bengali(bn, Indian language) new language added #675

Merged
merged 4 commits into from
Sep 26, 2020
Merged

Bengali(bn, Indian language) new language added #675

merged 4 commits into from
Sep 26, 2020

Conversation

Ayan-10
Copy link
Contributor

@Ayan-10 Ayan-10 commented Sep 25, 2020

@chirag-jn Bengali(bn-rIN) new language added.

Sorry for the mistakes.This is my 1st open source contribution so I made some mistakes. I added freshly. Please review it.

@chirag-jn
Copy link
Member

No issues. We can close down the old PR #674 in that case then.

@chirag-jn
Copy link
Member

This PR is a step towards #548

@chirag-jn chirag-jn added the ui/ux User Interface & User Experience Issues/Improvements label Sep 25, 2020
<string name="message_notice_create_some">কিছু তৈরি করে পুনরায় চেষ্টা করুন</string>
<string name="message_notice_visit_some">কিছু পরিদর্শন করে পুনরায় চেষ্টা করুন</string>
<string name="message_offline_file_deleted">অফ্লাইন ফাইল সফলভাবে সরানো হয়েছে</string>
<string name="message_progress_file_downloading">ফাইলটি ডাউনলোড হচ্ছে …</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@chirag-jn
Copy link
Member

Fixed issues with loading the translations on runtime. I guess @cpg we can merge this PR. @Ayan-10 can you go forward and translate for Hindi too?

@Ayan-10
Copy link
Contributor Author

Ayan-10 commented Sep 25, 2020

@chirag-jn Thank you so much. Yeah, I will love to. Although I don't know hindi that much but I will try my best.

@chirag-jn chirag-jn changed the title Bengali(bn-rIN) new language added Bengali(bn, Indian language) new language added Sep 25, 2020
@chirag-jn
Copy link
Member

Updated the key-value pair.

@cpg cpg merged commit 02345f1 into amahi:beta Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux User Interface & User Experience Issues/Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants