Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashlytics #327

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from
Open

Crashlytics #327

wants to merge 2 commits into from

Conversation

anubhavpulkit
Copy link
Contributor

@anubhavpulkit anubhavpulkit commented Jul 24, 2020

Description

Firebase Crashlytics is a lightweight, realtime crash reporter that helps you track, prioritize, and fix stability issues that erode your app quality. Crashlytics saves you troubleshooting time by intelligently grouping crashes and highlighting the circumstances that lead up to them.

Fixes #296

Type of Change:

  • Code
  • Quality Assurance

How Has This Been Tested?

Tested in the simulator and in firebase console.

Checklist:

  • My PR follows the style guidelines of this project

@anubhavpulkit
Copy link
Contributor Author

To build now we need to add googleService-info.plist file. The googleService-info.plist file contains configuration details, such as keys and identifiers, for the services that we have enabled for crashlytics.

@cpg cpg changed the base branch from feature/recent-files to beta July 25, 2020 11:35
@cpg
Copy link
Member

cpg commented Jul 25, 2020

I rebased it to be against beta .. please fix the conflict by updating the pods.

@anubhavpulkit
Copy link
Contributor Author

I rebased it to be against beta .. please fix the conflict by updating the pods.

Done all conflicts are resolved, the branch is now ready to merge.

@anubhavpulkit anubhavpulkit reopened this Jul 26, 2020
@cpg cpg added the question Further information is requested label Jul 29, 2020
@anubhavpulkit
Copy link
Contributor Author

About GoogleService-Info.plist file.

I think we have no privacy issue from GoogleService-Info.plist file because we need only Bundle identifier to download GoogleService-Info.plist file and Bundle identifier is easily available in public. Therefore I think adding GoogleService-Info.plist in the public repo is totally fine and it makes no harm to the privacy issue of our app.

firebase

https://console.firebase.google.com/u/0/project/amahi-3252a/overview

@cpg cpg removed the question Further information is requested label Aug 3, 2020
@cpg
Copy link
Member

cpg commented Aug 4, 2020

The documentation spells it clearly. Next time please don't forget to read the documentation.

@cpg cpg self-assigned this Aug 4, 2020
@chirag-jn
Copy link
Member

Please remember to remove GoogleService-Info.plist file from the other PR too #298

@anubhavpulkit
Copy link
Contributor Author

anubhavpulkit commented Aug 5, 2020

The documentation spells it clearly. Next time please don't forget to read the documentation.

Ok, @cpg I always remember to read the documentation before adding new features. From next time. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase Analytics and Crashlytics
3 participants