Allow configuration overrides #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 2, 2024 14:52
Added code formatting. Swapped factory for custom handler. Changed namespace. Removed handler. Refactored defaults. iFixed a return type. Committed out problematic code. Added Lagoon logs formatter. Revised code format. Updated Readme.
steveworley
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The current package does not allow configuration overrides which limits the control over how the logs are processed.
Furthermore, the package needs an uplift and congruence with other Lagoon logging plugins (e.g. Lagoon Logs drupal module)
Proposed solution
This PR introduces the following changes:
./config/logging.phpconfiguration that gets merged with the existing application configuration, allowing for overrides if needed.application,environmentandproject.LagoonLogsFormatterthat is consistent with the formatter of the Drupal plugin.