Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Persist circuits and tasks in batch execute #270

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Jun 17, 2024

Issue #, if available:
#255

Description of changes:
Starting with the changes from #260 and performing the additional work required to merge to main.

In particular, we need to:

Testing done:
tox

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feature: persist circuits in batch execute

* feature: Add test for batch_execute persistance

* fix: circuits attribute

* documentation: add doc for printing circuits from batch_execute

* fix: linting

* Add tasks, circuits

---------

Co-authored-by: Ryan Shaffer <[email protected]>
Co-authored-by: Tim (Yi-Ting) <[email protected]>
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7cfecb8) to head (03fe023).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #270   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines         1211      1243   +32     
  Branches       295       306   +11     
=========================================
+ Hits          1211      1243   +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yitchen-tim
Copy link
Contributor

yitchen-tim commented Jun 18, 2024

circuit is not compatible to batch_execute(). circuits is more general, when using execute() instead of batch_execute() , circuits can just return a list with one circuit. Going down this route, we can have circuit and circuits coexist, but put circuit on a deprecation path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants