Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typing for task results methods #1039

Merged
merged 4 commits into from
Oct 18, 2024
Merged

fix: correct typing for task results methods #1039

merged 4 commits into from
Oct 18, 2024

Conversation

AbeCoull
Copy link
Contributor

@AbeCoull AbeCoull commented Oct 11, 2024

Issue #, if available:

Description of changes:
Corrects the return type and docstring for these methods.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (36e32f6) to head (16426c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main     #1039    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          135       135            
  Lines         9033      9033            
  Branches      2029      1037   -992     
==========================================
  Hits          9033      9033            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AbeCoull AbeCoull marked this pull request as ready for review October 11, 2024 16:56
@AbeCoull AbeCoull requested a review from a team as a code owner October 11, 2024 16:56
jacofeld
jacofeld previously approved these changes Oct 16, 2024
@AbeCoull AbeCoull merged commit cc3698c into main Oct 18, 2024
26 checks passed
@AbeCoull AbeCoull deleted the fix_1038 branch October 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants