Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MacOS build to use GCC 14 #353

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

nirosys
Copy link
Contributor

@nirosys nirosys commented Nov 8, 2024

Issue #, if available: actions/runner-images#10213

Description of changes:
Recently GCC 11 was removed from all MacOS images. This PR updates our build & test to use GCC 14.

Might be worth seeing if we can auto-populate the alias so we don't have to keep this in sync.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 8, 2024

👎

/Users/runner/work/ion-c/ion-c/ionc/ion_allocation.c:95:42: error: pointer type mismatch in conditional expression [-Wincompatible-pointer-types]
   95 |     memcpy(dst->value, (is_empty) ? "\0" : src->value, (is_empty) ? 1 : src->length);

@nirosys
Copy link
Contributor Author

nirosys commented Nov 8, 2024

More reason to double down on getting rid of all of the warnings that ion-c produces, and enforcing a zero warning policy. Clang 15 defaults to treating this as a warning. GCC 14 raises it as an error.

@nirosys
Copy link
Contributor Author

nirosys commented Nov 8, 2024

Also:

/Users/glitch/Code/ion-c/ionc/ion_internal.h:112:71: error: passing argument 2 of 'ion_stream_read_byte' from incompatible pointer type [-Wincompatible-pointer-types]
  112 |                                   IONCHECK(ion_stream_read_byte((xh), &(xb)));  \
      |                                                                       ^~~~~
      |                                                                       |
      |                                                                       uint64_t * {aka long long unsigned int *}

@nirosys nirosys merged commit 46aebb0 into amazon-ion:master Nov 8, 2024
12 of 14 checks passed
@nirosys nirosys deleted the rgiliam/macos_gcc_update branch January 10, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants