Refactor namespace logic out of default command logic #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jobarr-amzn
approved these changes
Jul 2, 2024
| @@ -16,11 +16,20 @@ impl IonCliCommand for FromJsonCommand { | |||
| } | |||
|
|
|||
| fn is_stable(&self) -> bool { | |||
| false // TODO: Should this be true? | |||
There was a problem hiding this comment.
We've debated over whether or not there should be upconversion of e.g. timestamps before... but it seems like that's not something you'd want as the default behavior. Ideally it seems like you'd want the default to be a stable, lossless transformation.
I guess what I'm saying is that I don't see any reason this couldn't be stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up for #128.
Description of changes:
IonCliCommand'sis_stable()tofalseandis_porcelain()totrue.IonCliCommand.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.