Updates chapter on system module #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zslayton
approved these changes
Dec 4, 2024
| @@ -7,23 +7,20 @@ leverages the system symbol table, the text encoding that users typically intera | |||
| The system macros are more visible, especially to authors of macros. | |||
|
|
|||
| This chapter catalogs the system-provided symbols and macros. | |||
| The examples below use unqualified names, which works assuming no other macros with the same name are in scope. The unambiguous form `$ion::macro-name` is always available to use in the [template definition language](../macros/defining_macros.md#template-definition-language-tdl). | |||
| The examples below use unqualified names, which works assuming no other macros with the same name are in scope. | |||
| The unambiguous form `$ion::macro-name` is always available to use. | |||
There was a problem hiding this comment.
Unimportant, take it if you like it:
Suggested change
| The unambiguous form `$ion::macro-name` is always available to use. | |
| The unambiguous form `$ion::macro_name` is always available to use. |
Hyphens are illegal in macro names, which is arguably either a good thing (because it's clear macro-name is a placeholder) or a bad thing (because people might think kebab case is accepted.)
| However, the system symbols and macros are not permanent fixtures of the local symbol and macro tables respectively. | ||
|
|
||
| However, in Ion 1.1, the system symbol and macro tables have a system address space that is distinct from the | ||
| local address space, but can optionally be included in the user address space. |
There was a problem hiding this comment.
We have a lot of names for this--[local | user | application] address space. We should standardize on one and put it in the glossary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Follow up to #369, #370
Description of changes:
encodingto system symbol table where$ion_encodingused to be.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.